Add EIP: Non-fungible Token Bound Accounts #6551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
s-draft
|
The commit d82a653 (as a parent of 411a3c0) contains errors. |
SamWilsn
reviewed
Feb 23, 2023
EIPS/eip-6551.md
Outdated
| - An automated investment portfolio composed of multiple fungible assets | ||
| - A punch pass membership card granting access to an establishment and recording a history of past interactions | ||
|
|
||
| Several proposals have attempted to give ERC-721 tokens the ability to own assets. Some notable proposals include [ERC-998](./eip-998.md) and [ERC-6150](./eip-6150.md). |
There was a problem hiding this comment.
I would very much recommend removing these references. Your proposal will not be able to advance past Draft unless all proposals linked also advance past Draft.
Suggested change
| Several proposals have attempted to give ERC-721 tokens the ability to own assets. Some notable proposals include [ERC-998](./eip-998.md) and [ERC-6150](./eip-6150.md). | |
| Several proposals have attempted to give ERC-721 tokens the ability to own assets. |
There was a problem hiding this comment.
Ah, didn't realize that. Removed!
EIPS/eip-6551.md
Outdated
|
|
||
| For example, the token bound account with implementation address `0xbebebebebebebebebebebebebebebebebebebebe`, chain ID `1`, token contract `0xcfcfcfcfcfcfcfcfcfcfcfcfcfcfcfcfcfcfcfcf` and token ID `123` would have the following deployed bytecode: | ||
|
|
||
| ```! |
There was a problem hiding this comment.
I'm not familiar with the ! notation. What is it supposed to do?
There was a problem hiding this comment.
Oops, composed this in hackmd where the ! turns on line wrapping. Removed :)
SamWilsn
approved these changes
Feb 24, 2023
|
@eth-bot rerun |
|
All reviewers have approved. Auto merging... |
eth-bot
approved these changes
Feb 24, 2023
fulldecent
pushed a commit
to fulldecent/EIPs
that referenced
this pull request
Mar 13, 2023
* Initial proposal for token bound accounts * Updated preamble * Removed malformed EIP link * Fixed EIP-155 linking and relative asset path * Added EIP number * Updated filenames * Linting fixes * Additional linting fixes * Fixed linting for implementation headers * Removed draft EIP references and hackmd specific markdown
axelcabee
pushed a commit
to axelcabee/EIPs
that referenced
this pull request
May 6, 2023
* Initial proposal for token bound accounts * Updated preamble * Removed malformed EIP link * Fixed EIP-155 linking and relative asset path * Added EIP number * Updated filenames * Linting fixes * Additional linting fixes * Fixed linting for implementation headers * Removed draft EIP references and hackmd specific markdown
Hawthorne001
approved these changes
May 3, 2024
GAEAlimited
pushed a commit
to GAEAlimited/EIPs
that referenced
this pull request
Jun 19, 2024
* Initial proposal for token bound accounts * Updated preamble * Removed malformed EIP link * Fixed EIP-155 linking and relative asset path * Added EIP number * Updated filenames * Linting fixes * Additional linting fixes * Fixed linting for implementation headers * Removed draft EIP references and hackmd specific markdown
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md
We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met: